update Golanci-lint config#461
Merged
fbm3307 merged 2 commits intocodeready-toolchain:masterfrom Feb 18, 2025
Merged
Conversation
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
alexeykazakov,
jrosental,
metlos,
mfrancisc,
rajivnathan,
ranakan19,
rsoaresd and
xcoulon
as code owners
This was referenced Feb 17, 2025
Merged
Merged
xcoulon
approved these changes
Feb 17, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Golanci-lint action recently changed the golangci-lint verify command to by default be true. Change
This broke our Golanci-lint CI errorrepo1.
The fix is to remove the additional parameter which the verify doesn't allow
Checks
Did you run
make generatetarget? noDid
make generatechange anything in other projects (host-operator, member-operator)? noIn case of new CRD, did you the following? no
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.